search

adafruit / Adafruit_CircuitPython_DotStar

Dotstarrin' away in CircuitPython land
MIT License
46 stars 38 forks source link

dotstar Featherwing #47

Closed MBottinIUT closed 4 years ago

MBottinIUT commented 4 years ago

Hi, I have the Featherwing Dotstar module. I'm not an expert in CircuitPython, but the example on the 'https://learn.adafruit.com/dotstar-featherwing-in-circuitpython/text' page doesn't work. In fact, I have a feeling that the 'dotstar_featherwing.py' module class doesn't support text scrolling anymore. Am I wrong? If so, why didn't you leave these features in place? Best regards, Mike

kevinjwalters commented 4 years ago

This might belong in https://github.com/dastels/circuitPython_dotstar_featherwing ?

dastels commented 4 years ago

The adafruit_featherwing/dotstar_featherwing module is NOT the one used in the guide. The one used in the guide is linked via the community bundle and lives at https://github.com/dastels/circuitPython_dotstar_featherwing. The DotStar constructor call was out of date (parameters were changed), and has been updated. I just tried the examples with CP 5.3.0 and they worked fine.

tannewt commented 4 years ago

This is fixed by https://github.com/dastels/circuitPython_dotstar_featherwing/commit/0b5c42ce950581ae3d4c8486b131695daf8d8b3d. Thanks @dastels !

MBottinIUT commented 4 years ago

Thanks a lot. I got it all figured out. I thought it was the same module with different versions. Everything is fine now !