search

adafruit / Adafruit_CircuitPython_EMC2101

CircuitPython driver for EMC2101 brushless fan controller
MIT License
3 stars 9 forks source link

Add Missing Type Annotations - Partial #29

Open tcfranks opened 1 year ago

tcfranks commented 1 year ago

resolves #18

This is a PARTIALLY COMPLETE solution - still completing work on objects and methods in emc2101_fanspeed.py....Wanted to get the others (init.py, emc2101_lut.py, emc2101_ext.py, and emc2101_enums.py) up for feedback and review.

tekktrik commented 1 year ago

Do you intend to keep it all in this one review, or break it up across multiple PRs? If it's the latter, I'll unlink the issue so it doesn't get lost or forgotten. :)

tcfranks commented 1 year ago

I guess I anticipated feedback on the others that would require correction, and that I’d gety the last file annotated and completed with the rest.

There were pretty lot hanging fruit, so if that’s not the case, unlink the or and I’ll push the last when I get it done. I won’t get to it before this evening, at the earliest.

tcfranks commented 1 year ago

Thank you @FoamyGuy . I've been dragging my feet, I know. I'll be out of town for two weeks. I'll try to wrap this up when I get back.