search

adafruit / Adafruit_CircuitPython_EPD

e paper driver for circuit python
MIT License
41 stars 19 forks source link

Example fails with OverflowError: value must fit in 1 byte(s) #19

Closed mrmcwethy closed 5 years ago

mrmcwethy commented 5 years ago

I am using CP 4 rc3. I was told there was a recent change that checks on assignment for high-order bits truncation. The EPD library used to do & 0xFF when assigning to a buffer item, but that was removed. I think it is now really needed.

epd.py lines 131, 132 mcp_sram.py lines 74,75,84,85,113,114 all need & 0xFF added.

I am ready to fix this, if it is truely a bug.

makermelissa commented 5 years ago

Hi. Would you like to submit a PR?

mrmcwethy commented 5 years ago

I wlll.

Sent from Yahoo Mail on Android

On Sun, May 19, 2019 at 3:20 PM, Melissa LeBlanc-Williamsnotifications@github.com wrote:
Hi. Would you like to submit a PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

mrmcwethy commented 5 years ago

Done On Sunday, May 19, 2019, 3:27:35 PM MST, Michael McWethy mrmcwethy@yahoo.com wrote:

I wlll.

Sent from Yahoo Mail on Android

On Sun, May 19, 2019 at 3:20 PM, Melissa LeBlanc-Williamsnotifications@github.com wrote:
Hi. Would you like to submit a PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

makermelissa commented 5 years ago

Thanks, I'm testing it. :)

makermelissa commented 5 years ago

Fixed with #20.