Added Tri-Color SSD1681 Driver

adafruit / Adafruit_CircuitPython_EPD

e paper driver for circuit python

MIT License

41 stars 19 forks source link

Added Tri-Color SSD1681 Driver #45

Closed makermelissa closed 3 years ago

makermelissa commented 3 years ago

This PR does several things:

Adds a copy the existing SSD1681 (monochrome) driver to SSD1681B
Updates the existing SSD1681 driver to work as a Tri-Color display driver
Updates the examples to use the new drivers
Updates most examples to have consistent sets of initializers

ladyada commented 3 years ago

this is for support on raspberry pi specifically - since we have bonnet's that will use this chipset (all Eink displays went thru a revision, very annoying)

makermelissa commented 3 years ago

I talked to @ladyada and the decision was to remove the 1681b file. The duplicate-code check appears to be something that was enabled by default on a very recent version of pylint. For the pylinrc change, it basically compares all the files and sees that there are a lot of similarities and fixing it would require rewriting the entire library. I can look at modify each file to see if that fixes the huge pylint error.

Currently Blinka displayio does not support eInks, so this won't be deprecated until it does. :)

kattni commented 3 years ago

I will be looking into the Pylint update tomorrow. It is popping up across the board and causing issues.

tannewt commented 3 years ago

Currently Blinka displayio does not support eInks, so this won't be deprecated until it does. :)

Any plans to add it? You'd only need the displayio.EPaperDisplay class right?

I will be looking into the Pylint update tomorrow. It is popping up across the board and causing issues.

Thanks! I imagine a disable at the top of the file should fix it. Overall, it does seem like a reasonable check to have enabled though.

makermelissa commented 3 years ago

Thanks! I imagine a disable at the top of the file should fix it. Overall, it does seem like a reasonable check to have enabled though.

Unfortunately, this is a repo-level check rather than a file-level check and thus a simple disable at the top of any or even all files doesn't seem make a difference.

makermelissa commented 3 years ago

Any plans to add it? You'd only need the displayio.EPaperDisplay class right?

@tannewt, I just realized I never answered your question. Yes, here's the issue for it: https://github.com/adafruit/Adafruit_Blinka_Displayio/issues/3