adafruit / Adafruit_CircuitPython_EPD

e paper driver for circuit python
MIT License
41 stars 19 forks source link

Acep 7color #62

Open BlitzCityDIY opened 1 year ago

BlitzCityDIY commented 1 year ago

hihi @tannewt & @ladyada - here is the work i've tried so far on the ACeP support. still only getting black and white. i was trying to have it work with how the tricolor displays are written to but the issue with that, if i'm understanding everything correctly, is that the library expects two framebuffers for color displays and the acep only has one (i was referencing the arduino driver).

there's an if/else in _color_dup that checks if the black frame buffer and the color frame buffer are the same and if they are it recognizes it as a monochrome display. i have that commented out here for testing. i noticed in the circuitpython displayio version that there is a parameter that checks if it is an adv color display so maybe i should be adding something like that?

tannewt commented 1 year ago

It looks like this code is all geared towards single bit pixels. I think porting my displayio changes to blinka displayio would be easier because it already handles multi-bit colors.

makermelissa commented 1 year ago

It looks like this code is all geared towards single bit pixels. I think porting my displayio changes to blinka displayio would be easier because it already handles multi-bit colors.

Except I don't believe much of the e-ink infrastructure has actually been written for that library, which is why the release is still < 1.0.0.

tannewt commented 1 year ago

Ah, I see its still stubbed out. My bias is to move towards displayio but that's because I don't have experience with this library.

ladyada commented 1 year ago

ok we chatted and maybe try to create a new function for setting pixels in 'any' layer from 0-7 rather than hardcoding two.

github-actions[bot] commented 1 year ago

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

ladyada commented 1 year ago

ill hack on it from here :)