search

adafruit / Adafruit_CircuitPython_ESP32SPI

ESP32 as wifi with SPI interface
MIT License
103 stars 75 forks source link

Reorg code per request from orphan pr 69 #107

Closed mytechnotalent closed 4 years ago

mytechnotalent commented 4 years ago

This PR deprecates PR 69 as a year has passed as I was tied up with other responsibilities. The code base has changed significantly so there was a large merge conflict with the prior work. This new PR takes all of the recommendations of @mscosti @brentru @jerryneedell into account. @kattni apology for taking so long.

mytechnotalent commented 4 years ago

@tannewt there is no getpeername exposed in the Nina firmware https://github.com/adafruit/nina-fw/blob/master/main/CommandHandler.cpp. The getpeername from CPython exists here https://github.com/python/cpython/blob/e822e37946f27c09953bb5733acf3b07c2db690f/Modules/socketmodule.c#L3377.

Trying to add this API would be a major amount of work and to be honest without it following the convention of the rest of this lib I would not even know where to begin. Do you think this PR should simply be closed if it might not be a feature worth implementing?

tannewt commented 4 years ago

@mytechnotalent I don't think you need getpeername exposed from Nina because you already have a way to get the remote ip. I think you can call that API from your getpeername implementation.

mytechnotalent commented 4 years ago

Can you provide more information? Perhaps an example? I am not following.