search

adafruit / Adafruit_CircuitPython_ESP32SPI

ESP32 as wifi with SPI interface
MIT License
103 stars 75 forks source link

Add support for Bluepad32 gamepads #118

Closed ricardoquesada closed 3 years ago

ricardoquesada commented 3 years ago

This commit adds a new message to the SPI protocol: get_gamepad_data()

This new function uses the unused 0x60 message ID and requires the Bluepad32 firmware, since the Nina-fw firmware doesn't support it yet.

More information here: https://gitlab.com/ricardoquesada/bluepad32/-/blob/master/docs/plat_airlift.md

evaherrada commented 3 years ago

Hey @ricardoquesada could you run black and then commit those changes? Here are the instructions for doing that: https://learn.adafruit.com/improve-your-code-with-pylint/black

ricardoquesada commented 3 years ago

Hey @ricardoquesada could you run black and then commit those changes? Here are the instructions for doing that: https://learn.adafruit.com/improve-your-code-with-pylint/black

Thanks. There were a few warnings. I fixed them, updated pull-request and it is still failing.

What I'm doing is the following:

$ cd ~/src/Adafruit_CircuitPython_ESP32SPI
$ pylint adafruit_esp32spi/adafruit_esp32spi.py 

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

Any idea on what I'm missing? Thanks!

FoamyGuy commented 3 years ago

@ricardoquesada it's wanting the Black code formatter to be run on the code. If you already ran it once, then some of the subsequent changes may have caused it to find a new thing it wants formatted.

If you run the Black formatter on adafruit_esp32spi.py I think the current error will be resolved.

ricardoquesada commented 3 years ago

@ricardoquesada it's wanting the Black code formatter to be run on the code. If you already ran it once, then some of the subsequent changes may have caused it to find a new thing it wants formatted.

If you run the Black formatter on adafruit_esp32spi.py I think the current error will be resolved.

my bad... I was running pylint instead of black.

FoamyGuy commented 3 years ago

No worries. We use both so fixing up the pylint stuff is good as well, it would complain about that next ;-)

Thank you for working through all of the CI issues.

ricardoquesada commented 3 years ago

...create a separate library that takes in an ESP32SPI object and uses it. It shouldn't be done in this library.

sounds reasonable to me.