search

adafruit / Adafruit_CircuitPython_ESP32SPI

ESP32 as wifi with SPI interface
MIT License
103 stars 75 forks source link

Make these connection errors distinct from other error types. #164

Closed dannystaple closed 2 years ago

dannystaple commented 2 years ago

Thanks for improving this! The example scripts in examples should be updated to handle the new exceptions properly. For instance, ValueError probably should not be retried any more. There is probably code in Learn Guides and other libraries that will also need to be fixed.

@makermelissa FYI

This should get a major release version bump, since it is not upward compatible.

I've updated the examples and found a couple of other Runtime errors that should be something else.

tekktrik commented 2 years ago

The remaining CI failure was from the sphinx upgrade, re-ran it and it passed!