search

adafruit / Adafruit_CircuitPython_ESP32SPI

ESP32 as wifi with SPI interface
MIT License
103 stars 75 forks source link

Adding to the functionality of the ESP32 library in order to provide … #69

Closed mytechnotalent closed 4 years ago

mytechnotalent commented 5 years ago

…a printable echo of a remote IP connection in addition to optional code to control specific IP access to the server as the server can only take one connection at a time.

mytechnotalent commented 5 years ago

I don't understand what is causing Travis to fail any ideas?

jerryneedell commented 5 years ago

several issues reported here's https://travis-ci.com/adafruit/Adafruit_CircuitPython_ESP32SPI/builds/124470639#L288

mytechnotalent commented 5 years ago

I will remove it.

jerryneedell commented 5 years ago

Only remove it if you agree with my comments. I may have totally misunderstood your intent.

jerryneedell commented 5 years ago

Congratulations on satisfying PyLint!!

mytechnotalent commented 5 years ago

Thanks @jerryneedell and thank you for the help and suggestions to get the code more functional.

siddacious commented 5 years ago

Great work @mytechnotalent , thanks for your contribution!

Thanks to @jerryneedell and @mscosti for the reviews

tannewt commented 5 years ago

print calls in libraries are almost always bad because they force output on the library user. In the case of formatting an ip, it's usually a matter of making a class for the type of data (IP) and then implementing __str__ to format it for humans.

kattni commented 4 years ago

@mytechnotalent @brentru @jerryneedell Thank you for all your work on this PR. It has gotten behind the repo and requires resolving a merge conflict now. I'd like to see this included, but the PR needs to be updated and the final change requests addressed. If you need assistance with this, please let us know. Brent or Jerry: if the original author is unavailable, either of you is welcome to resolve the conflicts and push to this PR.

mytechnotalent commented 4 years ago

This PR is deprecated in favor of https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI/pull/107.