search

adafruit / Adafruit_CircuitPython_ESP_ATcontrol

Use the ESP AT command sent to communicate with the Interwebs
MIT License
20 stars 17 forks source link

Adding Support for Challenger 2040 WiFi boards. #49

Closed mperino closed 3 years ago

mperino commented 3 years ago

The current setup/init logic for this library is focused on the Particle Aragon. I added a If block to the examples with the default logic being the Particle (else) and (if board.board_id == "challenger_rp2040_wifi") being for the challenger. Should make it easier for adding other boards as well.

I moved the debug setting to a variable that is set in the early code.

For the Challenger boards I am getting some errors on AT commands not always sending back an expected OK. Have opened issue in Adafruit_CircuitPython_ESP_ATcontrol AT+CWLAP Does not return OK #48

I have also added a few comment lines that I think will help people. In aiocontrol_simpletest, I added a reminder that you need to create the feed in adafruitio, and what additional entries you need in the secrets file. In atcontrol_simpletest I added comments that the AP scan may fail and which lines to comment out if that is breaking (goes back to the opened issue).

evaherrada commented 3 years ago

@mperino Hey, myself and a coworker wrote a guide on using black, which is the thing that is currently failing. Let me know if it helps! https://learn.adafruit.com/improve-your-code-with-pylint/black

evaherrada commented 3 years ago

Black may actually fix the line too long error, but not necessarily, so if you can't figure out a way to fix it, feel free to ping me

mperino commented 3 years ago

@dherrada I fixed the long line manually. Do I need to create a new pull request, or is there a way to re-kick this one with the change.

evaherrada commented 3 years ago

@mperino Looks like you got it working. Good job! This whole CI thing is quite a steep learning curve.

ladyada commented 3 years ago

not tested (and this library is not really supported) but lgtm :) thanks!

mperino commented 3 years ago

So Much learning this week.. ALL a good thing.. Getting deeper into the weeds of Python, CircuitPython, and a bit of other stuff.. Hopefully I'll be contributing more