search

adafruit / Adafruit_CircuitPython_FeatherWing

CircuitPython classes for Adafruit FeatherWings
MIT License
11 stars 13 forks source link

pass ts_cs and sd_cs as arguments #65

Closed jerryneedell closed 3 years ago

jerryneedell commented 3 years ago

Should ts_cs be passed in as an argument like all the other pins.

https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing/blob/master/adafruit_featherwing/keyboard_featherwing.py#L68

also sd_cs https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing/blob/master/adafruit_featherwing/keyboard_featherwing.py#L75

FoamyGuy commented 3 years ago

Ah yes, I think it probably should pass them like the others. As-is I think it may not work with Feathers that have different pin names.

jerryneedell commented 3 years ago

I'll create a PR -- I have a "non-standard" board that I am using (umfreathers2) and would like to be able to use the library

FoamyGuy commented 3 years ago

resolved by #66