search

adafruit / Adafruit_CircuitPython_FeatherWing

CircuitPython classes for Adafruit FeatherWings
MIT License
11 stars 13 forks source link

Add typehints #74

Closed tekktrik closed 3 years ago

tekktrik commented 3 years ago

Shout out to whoever added those Sphinx markups, you made life much easier!

Closes: #72

tekktrik commented 3 years ago

Meant to tag this as resolving issue #72

jepler commented 3 years ago

Meant to tag this as resolving issue #72

I added text to the initial comment so that the issue would be linked.

tekktrik commented 3 years ago

Missed that, thanks!

tekktrik commented 3 years ago

I know there was a patch for regarding upgrading pylint, but I can't seem to get it, is that something I should do for this?

kattni commented 3 years ago

@tekktrik You don't need to do anything to upgrade Pylint on this repo, it happens behind the scenes. I've rerun the jobs - a number of the failures are a check we are disabling separately. I will rerun the jobs after that, and then you are welcome to take care of the rest of the linting issues in the repo (as per https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing/pull/75/files) and we can close Dylan's PR in place of this one. Otherwise, I need to merge Dylan's PR, and then you have to update this one to match anyway.

Are you up for linting this? You would need to update the imports, and disable ,duplicate-code exactly like I explained on Discord for the other repo. Please ignore the unspecified-encoding check, as it should be disabled globally in a bit here.

tekktrik commented 3 years ago

Definitely up for linting!

tekktrik commented 3 years ago

Just merged that linting branch into mine

tekktrik commented 3 years ago

Nevermind that, working on it now!

tekktrik commented 3 years ago

Changes from #75 incorporated!

tekktrik commented 3 years ago

Oh nice catch! Removed!

tekktrik commented 3 years ago

My pleasure! Thanks for all the assistance on these!