search

adafruit / Adafruit_CircuitPython_Fingerprint

CircuitPython library for talking to UART-based Fingerprint sensors
MIT License
54 stars 52 forks source link

View the fingerprint image using matplotlib. #50

Closed jim-mckeown closed 1 year ago

jim-mckeown commented 1 year ago

I needed to see and save the fingerprint image under Linux. Maybe others will find this useful.

FoamyGuy commented 1 year ago

@jim-mckeown Thanks for adding this functionality!

I think it would be best to keep the existing simpletest script as-is. This functionality could be added in a new example with something descriptive in it's name fingerprint_picturetest.py or something.

If I am understanding correct, this functionality is expected to linux only as well, not on microcontrollers. If that is the case we should add a comment near the top of the file indicating that it's for Linux only and doesn't work with microcontrollers.

jim-mckeown commented 1 year ago

Windows users may also be interested. The only other fingerprint image functionality I could find was the closed-source SFGDemo program. It only runs under windows and no source code is available.

On Sat, Apr 15, 2023, 8:43 PM foamyguy @.***> wrote:

@jim-mckeown https://github.com/jim-mckeown Thanks for adding this functionality!

I think it would be best to keep the existing simpletest script as-is. This functionality could be added in a new example with something descriptive in it's name fingerprint_picturetest.py or something.

If I am understanding correct, this functionality is expected to linux only as well, not on microcontrollers. If that is the case we should add a comment near the top of the file indicating that it's for Linux only and doesn't work with microcontrollers.

— Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint/pull/50#issuecomment-1509834789, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQQBRKVMJJLBZRRJAN7OJDXBKQW7ANCNFSM6AAAAAAW7LWJKI . You are receiving this because you were mentioned.Message ID: @.*** com>

jim-mckeown commented 1 year ago

I will start a new fork and pull request with the above suggestions.

jim-mckeown commented 1 year ago

@foamguy I canceled this pull request and started a new fork and new pull request with a separate example file as you suggested.

On Sat, Apr 15, 2023, 10:07 PM James M @.***> wrote:

Windows users may also be interested. The only other fingerprint image functionality I could find was the closed-source SFGDemo program. It only runs under windows and no source code is available.

  • Jim

On Sat, Apr 15, 2023, 8:43 PM foamyguy @.***> wrote:

@jim-mckeown https://github.com/jim-mckeown Thanks for adding this functionality!

I think it would be best to keep the existing simpletest script as-is. This functionality could be added in a new example with something descriptive in it's name fingerprint_picturetest.py or something.

If I am understanding correct, this functionality is expected to linux only as well, not on microcontrollers. If that is the case we should add a comment near the top of the file indicating that it's for Linux only and doesn't work with microcontrollers.

— Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint/pull/50#issuecomment-1509834789, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQQBRKVMJJLBZRRJAN7OJDXBKQW7ANCNFSM6AAAAAAW7LWJKI . You are receiving this because you were mentioned.Message ID: @.*** com>