search

adafruit / Adafruit_CircuitPython_Fingerprint

CircuitPython library for talking to UART-based Fingerprint sensors
MIT License
54 stars 52 forks source link

Example with image rendering functionality #51

Closed jim-mckeown closed 1 year ago

jim-mckeown commented 1 year ago

Example from modified fingerprint_simpletest.py adding image viewing and saving functionality using matplotlib and numpy. This has been tested on a Linux PC but should work under Windows or MacOS.

tekktrik commented 1 year ago

Looks like this is failing the GitHub Actions CI. You can use pre-commit to help find and fix the issues it's having. You can find information on installing and using pre-commit here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

jim-mckeown commented 1 year ago

I changed the import order and reformatted with black. Also added non-blocking mode in matplotlib.pyplot so the code will run properly from the command line.

jim-mckeown commented 1 year ago

Please have a look at the latest changes and let me know if any others are needed or would be helpful. Thanks.

jim-mckeown commented 1 year ago

Please have a look at the latest changes.

Just one thought about pyserial. Since it is already in requirements.txt, does it also need to be in optional_requirements.txt?