search

adafruit / Adafruit_CircuitPython_GPS

GPS parsing module for CircuitPython. Meant to parse NMEA data from serial GPS modules.
MIT License
75 stars 58 forks source link

stability improvements #47

Closed fvzeppelin closed 4 years ago

fvzeppelin commented 4 years ago

my NEO-7M likes to send this, so I need to catch it ;)

evaherrada commented 4 years ago

Run black . --target-version=py35 in this project's directory. You may need to install black with pip if you haven't already.

evaherrada commented 4 years ago

@fvzeppelin Otherwise, seems good. I don't see any potential for any breakages arising from this, and I have tested it on the MTK3339, so I'll merge this when it's passing the CI

fvzeppelin commented 4 years ago

@dherrada now, checks have passed :) But I could not test it on the target, yet.

evaherrada commented 4 years ago

@fvzeppelin No worries, black won't change anything functional. One more thing, change the version back to 3.6.3 and I can merge.

edit: That is, unless you haven't tested the first version of this PR on the NEO-7M. In that case, we can wait until you do that.

fvzeppelin commented 4 years ago

@dherrada I had tested the version before applying black with a NEO-7M and an ItsyBitsy M0 Express.

evaherrada commented 4 years ago

awesome. Merging