search

adafruit / Adafruit_CircuitPython_GPS

GPS parsing module for CircuitPython. Meant to parse NMEA data from serial GPS modules.
MIT License
75 stars 58 forks source link

Update the pre-commit and github workflow to move pylint to pre-commit. #59

Closed lesamouraipourpre closed 3 years ago

lesamouraipourpre commented 3 years ago

Also, disable duplicate-code check in examples.

evaherrada commented 3 years ago

@lesamouraipourpre Can you check that the changes you're making are the same as the ones in the place I linked? I think they are, but I just wanted you to check as well before I merge.

lesamouraipourpre commented 3 years ago

@lesamouraipourpre Can you check that the changes you're making are the same as the ones in the place I linked? I think they are, but I just wanted you to check as well before I merge.

Yes, it was essentially a copy-and-paste to add the pylint sections.

Confirmed with:

diff cookiecutter-adafruit-circuitpython/{%\ if\ cookiecutter.library_prefix\ %}{{\ cookiecutter.libraryprefix\ |\ capitalize\ }}{%\ endif\ %}CircuitPython_{{\ cookiecutter.library_name}}/.pre-commit-config.yaml Adafruit_CircuitPython_GPS/.pre-commit-config.yaml

jposada202020 commented 3 years ago

@dherrada :) according to what I read I guess we could merge this change. let me know. Thanks!

evaherrada commented 3 years ago

Sweet. Looks good. @jposada202020 Thanks for the reminder on this one

jposada202020 commented 3 years ago

No problem :) @dherrada