search

adafruit / Adafruit_CircuitPython_GPS

GPS parsing module for CircuitPython. Meant to parse NMEA data from serial GPS modules.
MIT License
75 stars 58 forks source link

Fix/Correct linting #72

Closed tekktrik closed 2 years ago

jkittner commented 2 years ago

f-strings seem to be not supported by all circuitpython boards see: https://github.com/adafruit/Adafruit_CircuitPython_GPS/pull/67#issuecomment-926913495

So I think except inside the tests they unfortunatelly can't be used.

The f-string suggestion from pylint should be disabled though (ca3885a) ?

tekktrik commented 2 years ago

Sounds good, I can add that to the file instead, thanks for the heads up!

tekktrik commented 2 years ago

And I'm not sure, I found it on https://circuitpython.org/contributing/library-infrastructure-issues and that's what came up when I ran pylint. If it's something else I'd be happy to work on it!

tekktrik commented 2 years ago

Please don't approve, pending changes per discussion found here: https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint/pull/35#pullrequestreview-795630349

tekktrik commented 2 years ago

Closing per discussion: https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint/pull/35#issuecomment-957938005