search

adafruit / Adafruit_CircuitPython_GPS

GPS parsing module for CircuitPython. Meant to parse NMEA data from serial GPS modules.
MIT License
75 stars 58 forks source link

use values for satellite dict access instead of items #97

Closed awordforthat closed 1 year ago

awordforthat commented 1 year ago

As @jkittner pointed out, items() returns a list of tuples of the form (key, value), so on the following line, an index of 4 will always error. The fix uses values() instead, so sat refers to a data structure that actually has a 5th element.

Future CI work will make sure that this will get caught by tests before merging (see discussion in PR#96 in this repo)

awordforthat commented 1 year ago

Thanks for the quick fix!

Multitasking!