search

adafruit / Adafruit_CircuitPython_HID

USB Human Interface Device drivers.
MIT License
377 stars 105 forks source link

Add french layout (with example) #54

Closed remisarrailh closed 3 years ago

dhalbert commented 4 years ago

Hi, this is very nice. Sadly, this library is frozen into various builds (especially CPX), and adding significantly more code to the library makes the frozen version of the library no longer fit on those builds.

This issue came up with a previous PR: see #46 and #53. If the KeyboardLayout class is refactored into a common class and then language specific pieces (either by subclassing or composition), then we can create new libraries for other keyboard layouts. They would be in separate repos.

remisarrailh commented 4 years ago

OK, I'll wait until KeyboardLayout class is refactored. 👍

In the meantime, if someone want to use the french layout You can find Adafruit_hid library (with french layout only) 6.x-mpy-20201105 here. Adafruit_HID FR

I'm working on examples for Circuit Python in french for my workshop at Labsud (that's why I need it) https://github.com/usini/CircuitPython_Exemples I'll probably translates these, afterwards.

kattni commented 3 years ago

Closing this for now. We can revisit it once we have refactored things.

AngainorDev commented 3 years ago

Gave a try at refactoring with ancestor and including your french layout. Working but likely to need further work https://github.com/AngainorDev/Adafruit_CircuitPython_HID/tree/layouts/adafruit_hid