Closed DJDevon3 closed 5 months ago
Noticed a simpletest code comment said brightness was 0-15. Pretty sure it should be (0.0 to 1.0) across all segment types now.
Docs on HT16K33.brightness
After further investigation the code comment is a hold over from when brightness used to be an integer from 0-15 introduced here 4 years ago.
Just seems that particular code comment wasn't changed when brightness was switched from int to float in this commit.
Noticed a simpletest code comment said brightness was 0-15. Pretty sure it should be (0.0 to 1.0) across all segment types now.
Docs on HT16K33.brightness
After further investigation the code comment is a hold over from when brightness used to be an integer from 0-15 introduced here 4 years ago.
Just seems that particular code comment wasn't changed when brightness was switched from int to float in this commit.