adafruit / Adafruit_CircuitPython_HT16K33

Adafruit CircuitPython driver for the HT16K33, a LED matrix driver IC.
MIT License
41 stars 29 forks source link

segments.py example missing display.show() or auto-write not working #27

Closed jerryneedell closed 5 years ago

jerryneedell commented 5 years ago

A line with display.show() needs to be added at the end of segments.py to actually display the "12AB" message.

the display.print(42) does auto-write but the dispaly of "12ab" does not appear unless display.show() is called.

Is this a bug with auto-write or an omission from the example?

auto-write should be enabled by default.

I found the same problem with display.scroll(). It did not auto-write. display.show() as needed.

jerryneedell commented 5 years ago

strange -- looking at the history, it is not clear when the dispaly.show() at the end was dropped. The commit on June 19 added auto-write but dids not delete the display.show() https://github.com/adafruit/Adafruit_CircuitPython_HT16K33/commit/10e8b74a3f2c02313bda0596c79012c93e5f64fb#diff-d68d927ae06851aade474b7855278c1c. I can't find the commit that actually removed it.

caternuson commented 5 years ago

I think this is an issue with forgetting to do a release after making some changes so it didn't get into the bundle. I should have done that. But it looks like adabot tagged a release a few days ago, so it should be in bundle now. Try with latest bundle release and see if that fixes it.

jerryneedell commented 5 years ago

Yup - that fixed it release 2.1.1 works - thanks!