search

adafruit / Adafruit_CircuitPython_HT16K33

Adafruit CircuitPython driver for the HT16K33, a LED matrix driver IC.
MIT License
41 stars 29 forks source link

Set raw digit raise error #63

Closed geekguy-wy closed 4 years ago

geekguy-wy commented 4 years ago

Added checking that will raise an error for digit and bitmask value to Seg14x4.set_digit_raw()

dhalbert commented 4 years ago

@makermelissa @geekguy-wy asked in discord about why you wanted a squash. I speculated it was just to reduce the number of commits. Is that right?

makermelissa commented 4 years ago

If you go into file changes, you'll notice a new file called examples/ht16k33_animation_demo.py, however that was already added in another PR by @geekguy-wy. It probably doesn't make a difference, but it's harder to review changes when it has duplicate commits.

geekguy-wy commented 4 years ago

So, do I or do I not do 'git rebase' in my repo??

makermelissa commented 4 years ago

Closing. Manually merged.