search

adafruit / Adafruit_CircuitPython_HT16K33

Adafruit CircuitPython driver for the HT16K33, a LED matrix driver IC.
MIT License
41 stars 29 forks source link

Pylint: arguments-out-of-order #72

Closed evaherrada closed 4 years ago

evaherrada commented 4 years ago

The Pylint failure:

************* Module adafruit_ht16k33.matrix
adafruit_ht16k33/matrix.py:176:15: W1114: Positional arguments appear to be out of order (arguments-out-of-order)

The line in question 176 return super()._pixel(y, x, color)

Are these arguments actually out of order or should I add a disable?

Referencing main issue: adafruit/Adafruit_CircuitPython_Bundle#232 @kattni

tannewt commented 4 years ago

This looks intentional to me and needs a pylint exception. @makermelissa would know for sure.

makermelissa commented 4 years ago

Yep, disable please.

evaherrada commented 4 years ago

@makermelissa @tannewt Ok. I've disabled it. Thanks

kattni commented 4 years ago

Closing this issue. PR is in process.