No LOL'ing with 7x4 Segment

adafruit / Adafruit_CircuitPython_HT16K33

Adafruit CircuitPython driver for the HT16K33, a LED matrix driver IC.

MIT License

41 stars 29 forks source link

No LOL'ing with 7x4 Segment #79

Closed Daviey closed 2 years ago

Daviey commented 3 years ago

Seg7x4 is feeling a bit unloved (:broken_heart: & :cry:) and could really do with a laugh to feel a bit better. However, L,l,O,o are prohibited characters and silently dropped.

Please help put a smile on Seg7x4's face. :laughing:

tekktrik commented 2 years ago

Is this still WIP? I was thinking of implementing a way to add something like a character set to the display that could be used for a few reasons:

To add characters not included in display hex numbers
To pick how to display characters with multiple ways of showing them ("H" and "h" can both be valid in seven segment)
To allow for displaying of characters that don't have clean seven segment displays (I've seen "w" be done in some convoluted way)
To allow for non-English letters (Wikipedia shows some other alphabets)

I see a linked PR so I wanted to check in.

tekktrik commented 2 years ago

Or would it be better to just open it up further under the current implementation, for letters like "L" and "O", but still prevent letters that don't have great representations, like "W"?

tekktrik commented 2 years ago

Thanks for the PR @FoamyGuy! I may work on an implementation that allows for use of a character library as a solution for further letters, let me know if you have any thoughts.

FoamyGuy commented 2 years ago

@tekktrik I like that idea, it would be nice if it had a list of letters that it is able to draw with the segments that it has and could use them with marquee.

tekktrik commented 2 years ago

Sounds great! I'll get on it in the new year!