search

adafruit / Adafruit_CircuitPython_HT16K33

Adafruit CircuitPython driver for the HT16K33, a LED matrix driver IC.
MIT License
41 stars 29 forks source link

Removed artifical limiting of 7x4 display (LOL) #80

Closed Daviey closed 2 years ago

Daviey commented 3 years ago

I needed more LOL'ing in my life, and a 7x4 segment display can help with this.

However, adafruit_ht16k33 filters this out for the 7x4 display which makes me super sad :cry:. This change allows the use of both upper and lower case L's and O's.

(also, matrix.py and segments.py had the eXecutable bit set, which has been dropped)

Fixes: adafruit/Adafruit_CircuitPython_HT16K33#79 Signed-off-by: Dave Walker (Daviey) email@daviey.com

deshipu commented 3 years ago

I wonder what is your use case for this? If you need to display arbitrary patterns, then just use a lower-level interface.

Daviey commented 3 years ago

I wonder what is your use case for this? If you need to display arbitrary patterns, then just use a lower-level interface.

I wanted to use marquee(), which internally uses print() which means it can't use the lower level interface set_digit_raw() with marquee(). If marquee() can start supporting set_digit_raw() - then that would be great.

deshipu commented 3 years ago

Sounds like a good idea: either extending the marquee to work with arbitrary patterns, or writing a version that does strikes me as a cleaner and more general solution.