Closed Docteh closed 2 years ago
Got it down to two complaints from pylint
The first about the unused decimal variable is easy enough: throw it out
Not sure what to do about the reused code complaint, so I'm going to hold for advice on that. I'm surprised it doesn't also complain about _text
but maybe its small enough to sneak by.
@kattni requested I review this PR :)
@Docteh this branch has conflicts with main that will need to be resolved.
Are you interested / willing to do the refactoring that Jepler recommended to use a base class in order to avoid code repetition where possible?
Closing this for now.
If @Docteh or anyone else who finds this is interested in getting the merge conflicts resolved and refactoring as mentioned in the review this can be re-opened, or a new PR created starting from this code branch
Hello,
The HT16K33 can drive 8 digits worth of 14 segment displays, so I made my own little board to try that out.
I also took a shot at driving multiple display modules as mentioned in Issue #74 There is a demo video at https://www.youtube.com/watch?v=E5bb6R1FgcE if one is needed.
I'm wishing really really hard that the Continuous Integration passes.
For
set_raw_digit()
I think that the function should be able to write anywhere on the display even if its "off screen"