adafruit / Adafruit_CircuitPython_HT16K33

Adafruit CircuitPython driver for the HT16K33, a LED matrix driver IC.
MIT License
41 stars 29 forks source link

Add typing #92

Closed tekktrik closed 2 years ago

tekktrik commented 2 years ago

I believe I typed this correctly. Was a little unsure of using the CircuitPython "_typing" library.

tekktrik commented 2 years ago

Addressed issues from pre-commit check

tekktrik commented 2 years ago

Thanks @gamblor21 and @FoamyGuy for the helpful feedback! Appreciate the help for a new contributor. Just resubmitted with changes per review comments.

tekktrik commented 2 years ago

It actually just kicked back on building the docs, was it because it failed importing '_typing' so it never imported I2C?

tekktrik commented 2 years ago

Actually, rereading the documentation, is '_typing' actually a real library. or should I create a Union named ReadableBuffer within the import instead?

FoamyGuy commented 2 years ago

Actually, rereading the documentation, is '_typing' actually a real library. or should I create a Union named ReadableBuffer within the import instead?

Im not familiar with _typing not sure if it's a real module or not, but I don't think it's one that we've used for any of these so far.

I'm not certain where the ReadableBuffer import should come from though.

I'll take a look into this one and see if I can figure out the right way to import it to make the sphinx build happier. But it's likely I won't be able to get to it until tomorrow evening.

tekktrik commented 2 years ago

Much appreciated! Let me know when you determine how to do it!

tekktrik commented 2 years ago

Awesome, changes made!

FoamyGuy commented 2 years ago

Try adding pillow to the requirements.txt file. I think that should make sphinx recognize the Image object.

tekktrik commented 2 years ago

Awesome, thanks for all the help

FoamyGuy commented 2 years ago

It wants an extra empty line at the end of requirements.txt as well. (picky CI). Thanks for working through the issues.

tekktrik commented 2 years ago

Haha no worries, thanks for all the help!