Closed tekktrik closed 2 years ago
Addressed issues from pre-commit check
Thanks @gamblor21 and @FoamyGuy for the helpful feedback! Appreciate the help for a new contributor. Just resubmitted with changes per review comments.
It actually just kicked back on building the docs, was it because it failed importing '_typing' so it never imported I2C?
Actually, rereading the documentation, is '_typing' actually a real library. or should I create a Union named ReadableBuffer within the import instead?
Actually, rereading the documentation, is '_typing' actually a real library. or should I create a Union named ReadableBuffer within the import instead?
Im not familiar with _typing
not sure if it's a real module or not, but I don't think it's one that we've used for any of these so far.
I'm not certain where the ReadableBuffer import should come from though.
I'll take a look into this one and see if I can figure out the right way to import it to make the sphinx build happier. But it's likely I won't be able to get to it until tomorrow evening.
Much appreciated! Let me know when you determine how to do it!
Awesome, changes made!
Try adding pillow
to the requirements.txt file. I think that should make sphinx recognize the Image object.
Awesome, thanks for all the help
It wants an extra empty line at the end of requirements.txt as well. (picky CI). Thanks for working through the issues.
Haha no worries, thanks for all the help!
I believe I typed this correctly. Was a little unsure of using the CircuitPython "_typing" library.