adafruit / Adafruit_CircuitPython_HTU21D

CircuitPython driver for Adafruit's HTU21D-F temperature and humidity sensor
MIT License
2 stars 9 forks source link

improving docs, adding .idea to gitignore #15

Closed jposada202020 closed 3 years ago

jposada202020 commented 3 years ago

As title describes

Built locally to verify

jepler commented 3 years ago

I don't know what ".idea" is, so this is based on my guess, but: please consider: for files created by your particular development environment, you can put the patterns in a "global ignore" file so that they are ignored in every git repository you place on your system.

One philosophy of .gitignore is that the project one is for files created by interacting with the project in "the standard way", like building and testing the software. An advantage of this philosophy is that it's not scalable to put the patterns for every development environment in every git repo, especially since having many patterns can slow git down (though this is much better than it used to be, at least on linux), and you don't have to make a special request in each project you want to contribute to!

In the CircuitPython modules, we like for all the various files like .gitignore, .github/workflows/build.yml, etc., to have exactly the same content whenever possible, so that doing mass updates of these files can be done by simple patches, so we also think it could reduce effort for us in the long run.

For more details and how-to, see https://stackoverflow.com/questions/7335420/global-git-ignore https://docs.github.com/en/github/getting-started-with-github/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer and other resources that an internet search can find!

jposada202020 commented 3 years ago

@jepler Valid Points. Thanks However this is included in other libraries already as well. Just to put a few

kattni commented 3 years ago

To clarify, @jposada202020 @jepler, .idea is the directory created when you start PyCharm from within a working directory. I use PyCharm, and am definitely responsible for adding it to some of the libraries. It is fine to add it for now if you run into it.

I am going to file an issue on cookiecutter to suggest updating our .gitignore to include the additional files added by popular IDEs, as we are running into this more often with more diverse folks contributing to the libraries. I feel we would benefit from a more robust .gitignore so folks are not forced to deal with these things locally.

jposada202020 commented 3 years ago

@kattni thanks for the comments. will do