Closed dglaude closed 3 years ago
Ok, and pylint believe there is duplicate code because Keybow 2040 use a very similar lookup table (even if it only contain 16 entries and at least 4 entries do not exist in led-shim/matrix5x5 table.
Ok, and pylint believe there is duplicate code because Keybow 2040 use a very similar lookup table (even if it only contain 16 entries and at least 4 entries do not exist in led-shim/matrix5x5 table.
I think the duplication is coming from pixelrgb
instead of the lookup. I think you can create a parent class for 5x5 and keybow that adds pixelrgb for both.
@dglaude :) would you be able to work on this? thanks
Unfortunately, the current pixel_addr
doesn't work for this led matrix. (Video below)
The test code is slightly modified from the example to repeat endlessly.
https://user-images.githubusercontent.com/70200140/121439010-f6486780-c97c-11eb-8339-a846aa2dbc24.mp4
If I have time this weekend I'll try to work out the correct values.
Hi @dglaude.
I believe I've got this working correctly and passing pre-commit: https://user-images.githubusercontent.com/70200140/121524981-c6867780-c9ef-11eb-9e24-695349321be2.mp4
If you can give me write permission to this branch, I push a commit with the changes.
Superseded by #45
This is not tested on the real hardware, so it has to be considered draft until this is tested.
Room for improvement: