search

adafruit / Adafruit_CircuitPython_IS31FL3731

CircuitPython driver for the IS31FL3731 charlieplex IC
MIT License
22 stars 25 forks source link

"fade" method throws Exception when both params are None #52

Closed EAGrahamJr closed 1 year ago

EAGrahamJr commented 1 year ago

https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731/blob/97eb72a132f0a1349b2276cbc39539725f90515f/adafruit_is31fl3731/__init__.py#L193

It seems there's a missing return that should occur when both parameters are None. If that does not occur, line 209 will (obviously) fail.

tannewt commented 1 year ago

Would you mind making a PR? I think you are right what the fix is. https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github