adafruit / Adafruit_CircuitPython_MCP2515

A CircuitPython library for working with the MCP2515 CAN bus controller
MIT License
20 stars 14 forks source link

Added xtal frequency table for 8MHz #15

Closed casainho closed 1 year ago

casainho commented 1 year ago

This library did not work with MCP2515 modules with 8MHz xtal, only for 16MHz. I expanded the table to include the 8MHz. The default value still is the 16MHz.

casainho commented 1 year ago

I can not understand the existing errors on CI, can someone please tell me what I need to do??

image

tekktrik commented 1 year ago

You can run pre-commit locally to run black (the formatter tool) and let it reformat the code the way it wants, and then push those changes. That should resolve the CI issues.

casainho commented 1 year ago

You can run pre-commit locally to run black (the formatter tool) and let it reformat the code the way it wants, and then push those changes. That should resolve the CI issues.

Thanks @tekktrik. For some reason I could not find a solution, pre-commit is failing on my Linux Ubuntu 22.10. So I am not able to move forward with this.

tekktrik commented 1 year ago

What is the error you're getting?

casainho commented 1 year ago

What is the error you're getting?

Got it solved as it was the same that is as an alert on run pre-commit locally page.

Will push the little changes later.

casainho commented 1 year ago

So, all checks passed.

I hope this PR is on your interest and that you will accept it.

casainho commented 1 year ago

I did the changes your requested - hope everything is fine now.

casainho commented 1 year ago

Hope is ok now.