When available, use core `Message` and `RemoteTransmissionRequest`

adafruit / Adafruit_CircuitPython_MCP2515

A CircuitPython library for working with the MCP2515 CAN bus controller

MIT License

21 stars 14 forks source link

When available, use core `Message` and `RemoteTransmissionRequest` #18

Closed jepler closed 1 year ago

jepler commented 1 year ago

…classes

Otherwise, a user may unintentionally send a canio.Message to an adafruit_mcp2515.MCP2515 instance, and it will be incorrectly interpreted due to the type checking for whether the message is a RemoteTransmissionRequest

tannewt commented 1 year ago

@jepler You requested a review but didn't answer my question. :-)

jepler commented 1 year ago

I'd like to leave the classes where they are for now. Moving them will lead to problems making them appear at the right location within the sphinx documentation (they're missing from documentation right now for other reasons, which I'm working on ...)