search

adafruit / Adafruit_CircuitPython_MLX90640

A pure Python MLX90640 driver
MIT License
65 stars 20 forks source link

Update mlx90640_pygamer.py #7

Closed dglaude closed 4 years ago

dglaude commented 4 years ago

Use simpleio.map_range, remove custom function, more comments, cleaning, rename to max_t and min_t, general improvement.

No new functionality, just possibly easier to understand code and removing a custom function doing map_range.

dglaude commented 4 years ago

This should fix #6

caternuson commented 4 years ago

Looks good. Did you also test just to make sure it all still runs as expected?

dglaude commented 4 years ago

Yes, I have recovered my hardware and it was tested.

Actually, I never tested on Adafruit Stemma/breakout but only on my older Pimoroni Breakout Garden version. This is why I would love to see someone plugging a Stemma cable between a PyGamer and the Adafruit mlx90640 breakout board. (please take a picture).

I also have a PyPortal, so I may do a version with that resolution (but first I need to find/build a Stemma to Pimoroni Breakout Garden cable).

caternuson commented 4 years ago

OK. Those are just different ways of making the I2C connection. So shouldn't really matter in terms of testing the code. As long as you had some hardware setup for testing, should be fine.