search

adafruit / Adafruit_CircuitPython_MiniMQTT

MQTT Client Library for CircuitPython
Other
73 stars 50 forks source link

Make MQTT__init__ arguments keyword-only #121

Closed tekktrik closed 1 year ago

tekktrik commented 1 year ago

This is API-breaking, but hopefully makes using the library less prone to errors. I couldn't find any existing libraries or Learn Guides (save for one that's already broken with regards to API since it hasn't been updated for the last API-breaking change to MQTT.__init__()).

Resovles #120

tekktrik commented 1 year ago

I think it's fine, but I'll sit on tonight and see if anyone in #circuitpython-dev knows more about that!

tekktrik commented 1 year ago

Converted to draft so it doesn't merge before I can ask about this!

dhalbert commented 1 year ago

I agree it's fine, with a major version bump, if you've checked the Learn Guides repo and the library examples.

tekktrik commented 1 year ago

Checked the libraries and Learn Guides repositories, we're good!