search

adafruit / Adafruit_CircuitPython_MiniMQTT

MQTT Client Library for CircuitPython
Other
80 stars 49 forks source link

remove the workaround for buggy recv_into() #157

Open vladak opened 1 year ago

vladak commented 1 year ago

The \x00 literal should be removed https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/blob/342b8c99b2c8f10b605cc8311bf5f394f4d18e92/adafruit_minimqtt/adafruit_minimqtt.py#L984 once https://github.com/adafruit/circuitpython/issues/7606 is fixed.

vladak commented 1 year ago

This should probably wait for some time for the CP versions with the fix to percolate to the wide public. This could take a long time, I think.

brentru commented 1 year ago

Both of these were added to CircuitPython as of 8.1.0 beta 1, let's keep this code in until 8.1.0 is stable and released.

vladak commented 1 year ago

8.1.0 has been stable as of last week it seems.