search

adafruit / Adafruit_CircuitPython_MiniMQTT

MQTT Client Library for CircuitPython
Other
72 stars 50 forks source link

Fix #148 loop method blocking with timeout of 0 #184

Closed rjauquet closed 5 months ago

rjauquet commented 8 months ago

Hi folks -- I've run into this issue on the Feather RP2040: https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/issues/148

Not too sure if this is the proper fix for everyone, but this unblocked our team so I thought I'd share a PR. Happy to fix anything up if this isn't quite right.

FoamyGuy commented 6 months ago

@rjauquet it seems the new version of the test loop script did not pass: https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/actions/runs/6805249363/job/18504384141#step:2:956

Can you check into that and see what will be required to get it to pass?

rjauquet commented 5 months ago

Yeah I will have a look today!

rjauquet commented 5 months ago

I believe the constraint just needed to be loosened now that the timeout is passed through -- the fake method will only be called once as it has the same timeout as the original call instead of always having a timeout of 1 second.

Kheirlb commented 5 months ago

I would approve this if I could. Another friendly ping for the maintainers to take a look.

brentru commented 5 months ago

@rjauquet Thank you for this PR. It has been reviewed,approved and merged. A release will follow shortly :)