use the neopixel_cleanup method if available from BlinkA.

adafruit / Adafruit_CircuitPython_NeoPixel

CircuitPython drivers for neopixels.

MIT License

304 stars 98 forks source link

use the neopixel_cleanup method if available from BlinkA. #99

Closed jamesrusso closed 3 years ago

jamesrusso commented 3 years ago

Use the neopixel_cleanup method from the BlinkA module if it is available. See https://github.com/adafruit/Adafruit_Blinka/pull/379 for the change on the upstream module.

tannewt commented 3 years ago

I'd rather not change this for one specific implementation. I've replied on your Blinka PR and will follow up there.

jamesrusso commented 3 years ago

Ahh, I see and would then agree if there are multiple implementations. I couldn't find any other implementations. We can take the discussion over to BlinkA. I might not have a good handle on the full architecture and abstractions involved.

tannewt commented 3 years ago

@jamesrusso The other implementation is native CircuitPython. It does data transmission all within the write method.