search

adafruit / Adafruit_CircuitPython_PCA9685

Adafruit CircuitPython driver for PCA9685 16-channel, 12-bit PWM LED & servo driver chip.
MIT License
120 stars 64 forks source link

[doc] Example of servo sweep is wrong #35

Closed jvalrog closed 3 years ago

jvalrog commented 3 years ago

The code for that example is wrong. It lacks delays so the sweep is useless.

The example file is this: https://github.com/adafruit/Adafruit_CircuitPython_PCA9685/blob/master/examples/pca9685_servo.py

And it differs from this other one from the Motor library (it's actually the same example but this one has delays): https://github.com/adafruit/Adafruit_CircuitPython_Motor/blob/master/examples/motor_pca9685_servo_sweep.py

ladyada commented 3 years ago

hi please submit a PR for a version with delays then

jposada202020 commented 3 years ago

Closed by #36