Closed jepler closed 1 month ago
I think all the new directives & instructions are handled. However, I'd like to wait to merge this until the new StateMachine constructor parameters are supported in the core, just in case some changes end up needed there.
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.
oops, re-requested review but I missed a couple of points. will continue fixing.
OK now it's actually read for re-review (though I'm not likely to act on anything today or probably before monday so no rush)
New StateMachine constructor parameters will need to be added in the core. However, when these features are not used, the new constructor parameters will not be in
pio_kwargs
so backward compatibility is preserved.Directives:
Instructions:
Closes #67