search

adafruit / Adafruit_CircuitPython_PM25

CircuitPython library for PM2.5 sensors
MIT License
28 stars 16 forks source link

Library to package #8

Closed dglaude closed 3 years ago

dglaude commented 4 years ago

This split the single file library into a multi-file package in a folder. That way I2C version and UART version can be included separately while sharing some code in init.

dglaude commented 4 years ago

It seems to pass all the test. This is a fix for #5 that limit memory usage in any case. Please consider this better than #7

dglaude commented 4 years ago

I think I resolved all the change request, including api.rst. The only thing I would like to argue is that there should be two example rather than one, an I2C version and an UART version.

Should I rename and simplify the current by remove all the UART comment, and make an UART only version?

dglaude commented 3 years ago

Maybe those two learn guide will need attention once this is approuved:

FoamyGuy commented 3 years ago

I found another learn guide that will also need a small update when this PR gets merged. https://learn.adafruit.com/diy-air-quality-monitor/code-usage

@kattni and @brentru If this is ready to merge, I can work on updating the learn guides and their code if you want?

kattni commented 3 years ago

@FoamyGuy Please merge this and release the library, and then proceed onto updating the guides. That would be greatly appreciated - thank you!