search

adafruit / Adafruit_CircuitPython_PortalBase

Base Library for the Portal-style libraries.
MIT License
18 stars 17 forks source link

Status lights don't match documentation #83

Closed makermelissa closed 1 year ago

makermelissa commented 1 year ago

According to https://learn.adafruit.com/adafruit-pyportal/pyportal-hardware-faq#faq-3023990, the lights should act as follows:

Red = not connected to WiFi Blue = connected to WiFi Yellow = fetching data Blue = got data Cyan = file opening

The status colors are changeable at: https://github.com/adafruit/Adafruit_CircuitPython_PortalBase/blob/main/adafruit_portalbase/network.py#L59-L65

I see several issues here:

  1. STATUS_CONNECTED is never used.
  2. It looks like the get_strftime() function in network is not setting the status colors.
  3. It appears the connected color is currently set to green.
  4. It appears the Got Data is blue, though the original comments from the PyPortal library suggest it should have been green (https://github.com/adafruit/Adafruit_CircuitPython_PortalBase/blob/main/adafruit_portalbase/network.py#L281).
  5. The value for STATUS_FETCHING suggests more of an orange color rather than yellow.
makermelissa commented 1 year ago

I changed docs to show Green for Got Data as well as code, which I believe was the correct color.