search

adafruit / Adafruit_CircuitPython_ProgressBar

Dynamic progress bar widget for CircuitPython displays
MIT License
6 stars 9 forks source link

width and height attributes clash with Tilegrid #17

Closed mtowara closed 3 years ago

mtowara commented 3 years ago

Hi, it seems to me that width and height return self._width and self._height of the displayio.Tilegrid superclass, and thus alway (1,1). Thus the library is currently broken, as progress is not calculated correctly. I'll provide a PR shortly.

Cheers!

brentru commented 3 years ago

@mtowara Hi, the tilegrid docs don't seem to share the private properties of this library. It uses width and height instead of _width and _height like this library does. (https://circuitpython.readthedocs.io/en/5.0.x/shared-bindings/displayio/TileGrid.html#displayio.TileGrid)

mtowara commented 3 years ago

hm, then maybe its an issue with the versions on pyPI (I'm running on raspi Zero W), will check versions and come backt to you.

mtowara commented 3 years ago

It seems I'm using this. The circuitpython docs seem to refer to the C-bindings while this is a native Python implementation? https://github.com/adafruit/Adafruit_Blinka_Displayio/blob/master/displayio/tilegrid.py

FoamyGuy commented 3 years ago

resolved by #18