Update show_QR - Githubissues

adafruit / Adafruit_CircuitPython_PyPortal

CircuitPython driver for Adafruit PyPortal.

MIT License

45 stars 56 forks source link

Update show_QR #31

Closed caternuson closed 5 years ago

caternuson commented 5 years ago

Just an idea for #30

ladyada commented 5 years ago

ill take anything cause current code isnt working at all :D

caternuson commented 5 years ago

Sure. Was this suppose to be any fancier than just "clear screen and show QR code"?

ladyada commented 5 years ago

its pretty simple, yeah

caternuson commented 5 years ago

Generally works. This:

Adafruit CircuitPython 4.0.0-rc.1 on 2019-04-23; Adafruit PyPortal with samd51j20
>>> from adafruit_pyportal import PyPortal
>>> pp = PyPortal()
ESP firmware: bytearray(b'1.2.2\x00')
Set background to  0
No SD card found: no SD card
>>> pp.show_QR(b'hello world', 8, 20, 20)

gives this: qr_pyportal which was tested here: https://zxing.org/w/decode.jspx and spit back expected result: qr_test

Note weird border quirk might be related to this: https://github.com/adafruit/circuitpython/issues/1839

ladyada commented 5 years ago

fine by me!

caternuson commented 5 years ago

@ladyada want me to version bump this?

ladyada commented 5 years ago

yes plz!

caternuson commented 5 years ago

Done! Bumped major ver since the function call changed.

ladyada commented 5 years ago

amazing, thank you thank you carter :)