wait_for_frame fails with CP 5.x

jerryneedell commented 4 years ago

Does this call just have to be removed?

https://github.com/adafruit/Adafruit_CircuitPython_PyPortal/blob/master/adafruit_pyportal.py#L553

It seems to work OK if I delete it -- will thst cause any problems for CP 4.x?

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 5.0.0-alpha.4-72-g7f1bc48a8 on 2019-09-20; Adafruit PyPortal with samd51j20
>>> 
>>> import pyportal_simpletest
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "pyportal_simpletest.py", line 10, in <module>
  File "adafruit_pyportal.py", line 245, in __init__
  File "adafruit_pyportal.py", line 243, in __init__
  File "adafruit_pyportal.py", line 553, in play_file
AttributeError: 'Display' object has no attribute 'wait_for_frame'
>>> 
>>>

ladyada commented 4 years ago

@tannewt is there any dox on the new screen drawing timing?

jerryneedell commented 4 years ago

I removed line 553 and ran it with/without a pyportal_starup.wav on both Cp4.1.0 and CP5.0alpha-4 -- seems to work I put in a PR -- you can use or close as you see fit.

tannewt commented 4 years ago

@ladyada The only doc I know of is the API doc here: https://circuitpython.readthedocs.io/en/latest/shared-bindings/displayio/Display.html#displayio.Display.refresh

Thanks @jerryneedell, should be ok to remove.

adafruit / Adafruit_CircuitPython_PyPortal

wait_for_frame fails with CP 5.x #53