search

adafruit / Adafruit_CircuitPython_PyPortal

CircuitPython driver for Adafruit PyPortal.
MIT License
45 stars 56 forks source link

Add a parameter to set the maximum splash size #7

Closed dastels closed 5 years ago

ladyada commented 5 years ago

dya wanna just make it like 10? dont forget you can group things into groups

dastels commented 5 years ago

I didn't think of grouping them. I could combine the 2 weaker views and 2 alarm views. The downside is that the code becomes bulkier because things have to be created separately rather than with a loop. Also, I'm fine with making the max 10, but a defaulted parameter feels better to me.

ladyada commented 5 years ago

i did this in a previous merge so its good to go now :)