search

adafruit / Adafruit_CircuitPython_PyPortal

CircuitPython driver for Adafruit PyPortal.
MIT License
45 stars 56 forks source link

Default param for text_font #72

Closed cpirnat closed 3 years ago

cpirnat commented 4 years ago

Currently text_font on PyPortal class is set to None. Is there a chance we could utilize termalio font for a default font?

siddacious commented 4 years ago

What is the issue you are trying to solve? Please give a code example of what you are trying to do that isn't working

cpirnat commented 4 years ago

This would assist the helper library in be able to write text to display without the need of manually importing a font by the end user.

On Apr 6, 2020, at 1:51 PM, siddacious notifications@github.com wrote:

 What is the issue you are trying to solve? Please give a code example of what you are trying to do that isn't working

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

siddacious commented 4 years ago

That seems useful; can you give a mock example of how you would like it to work? What specific code do you have in mind to write that won't work as is?

text_font takes a string path to a font file which terminalio.FONT is not, so it would not be as simple as adding a default value.

evaherrada commented 4 years ago

hi @cpirnat Are you still planning on working on this?

makermelissa commented 3 years ago

I implemented this in the MatrixPortal library, so adding it to here should be pretty straightforward. In fact, I may have done this already on a PyPortal and have it floating around somewhere. I think there were only a handful of places special cases needed to be addressed.

makermelissa commented 3 years ago

Ah yes, I found it. :)