search

adafruit / Adafruit_CircuitPython_PyPortal

CircuitPython driver for Adafruit PyPortal.
MIT License
45 stars 56 forks source link

change from using adafruit_sdcard to sdcardio #83

Closed cjsieh closed 3 years ago

cjsieh commented 3 years ago

Change from adafruit_sdcard to sdcardio .

cjsieh commented 3 years ago

This is for https://github.com/adafruit/circuitpython/issues/3309. Note that adafruit_sdcard has issues and fails on the PyPortal and PyGamer.

cjsieh commented 3 years ago

pylint errors because of upgrade of pylinit to 2.6.0 .

ladyada commented 3 years ago

@makermelissa hey hey this needs the new exceptionizalation

makermelissa commented 3 years ago

Ok, should be quick. I'll submit a PR.

makermelissa commented 3 years ago

The pylint updates are now merged in. @cjsieh, please pull in latest changes from repo and push again.

FoamyGuy commented 3 years ago

I think the previous actions issue was a temporary problem. Something in the installing dependencies section failed to download the proper file. I re-ran the jobs and it did get past that issue.

After that it did need one minor change in the docs config file to include sdcardio in the list of mocked imports.

tannewt commented 3 years ago

@FoamyGuy Mind retesting this? Thanks!

FoamyGuy commented 3 years ago

I retested this. Still working successfully on 6.0.0-alpha.3 and no longer crashes on import on 5.3.1.