added pylint to project and update code

[mrmcwethy]

Lint all the libraries! #475

Not tested

[mrmcwethy]

https://github.com/adafruit/circuitpython/issues/475

[mrmcwethy]

Ready to re-review.

[mrmcwethy]

ok, i am done with the 2nd round of testing. does the _DISPLAYON missing explain @kattni problem with drivers?

[deshipu]

Does the _DISPLAYON missing explain @kattni problem with drivers?

I think so.

[mrmcwethy]

@kattni what does your main.py look like?

[kattni]

@mrmcwethy The following:

import busio
import digitalio
import board
from adafruit_rgb_display import color565
import adafruit_rgb_display.ssd1331 as ssd1331
spi = busio.SPI(clock=board.SCK, MOSI=board.MOSI, MISO=board.MISO)
display = ssd1331.SSD1331(spi, cs=digitalio.DigitalInOut(board.D5),
                               dc=digitalio.DigitalInOut(board.D11), rst=digitalio.DigitalInOut(board.D9))

while True:
    display.fill(0x7521)
    display.pixel(32, 32, 0)

[deshipu]

I got the SSD1331 display to work after this library was forked from mine. If you look at the MicroPython library, you will see the fixed setup code there: https://github.com/adafruit/micropython-adafruit-rgb-display/blob/master/ssd1331.py#L52-L75

However, I believe that this would be a separate issue and a separate pull request.

[kattni]

I have the SSD1331 working. I'm going to make a separate PR to resolve it since it's an issue with the current version of the driver as well.

[mrmcwethy]

Now that i have removed the "abstract functions" can this be merged?

Also resolved conflicts to SSD1331.py

[mrmcwethy]

I am happy to commit resolved conflicts. If someone else does it, take the "lint" changes over master.

[kattni]

Current testing status: the ILI9341 and the ST7735 (non-R version) still need to be tested.

All other displays have been successfully tested.

[kattni]

Adafruit does not carry the ST7735, only the ST7735R. ILI9341 tested successfully. That's everything! Great job!