search

adafruit / Adafruit_CircuitPython_RGB_Display

Drivers for RGB displays for Adafruit CircuitPython.
MIT License
133 stars 52 forks source link

Optional Type hint fails #112

Closed eichblatt closed 1 year ago

eichblatt commented 1 year ago

This line fails when I try importing this library.

https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display/blob/6ca64553a5f3e4aa718b2ee7ac8e4a0c07a6019b/adafruit_rgb_display/st7735.py#L196

FoamyGuy commented 1 year ago

@eichblatt can you post the full error?

If possible can you also try the previous release (found here: https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display/releases/tag/3.11.0 ) The library was just recently updated, it's possible we need another tweak on top to get that portion fixed.

tekktrik commented 1 year ago

My guess is it's failing because Optional is being given a module as an input instead of the DigitalInOut class, I can submit a fix and see if that fixes it.

eichblatt commented 1 year ago

Sorry for the terse post. By the time I identified the problem, I had already reverted to the old version that I knew worked. So I could not reproduce the error, or find it in my log. But I wanted to make sure that you knew, and figured a terse message was better than no message.

I will unpin the version, and update again. If it breaks, I will collect the error messages and post here.

Thank you!!