search

adafruit / Adafruit_CircuitPython_RGB_Display

Drivers for RGB displays for Adafruit CircuitPython.
MIT License
131 stars 52 forks source link

Allow image drawing in subscreen areas #50

Closed Johennes closed 4 years ago

Johennes commented 4 years ago

This extends the image method with two additional arguments for the image origin on the screen. The previous exact size check was adapted to ensure that the image drawn at the supplied origin does not exceed the display dimensions.

The changes allow to update a smaller part of the screen with an image which is especially benefitial on lower end hardware. Some example test results from a Rasberry Pi Zero:

Fixes: #48

Note that this was based off of my changes in #47 and will have to be rebased before merging.

makermelissa commented 4 years ago

As a note to reviewers, it appears this PR is dependent on #47 being approved, so I'll grab this after I have a chance to review #47.

makermelissa commented 4 years ago

@Johennes #47 was merged. Do you want to go ahead and rebase? Thanks

Johennes commented 4 years ago

👌 Will take care of it after work today.

makermelissa commented 4 years ago

Sounds good. Thanks!

Johennes commented 4 years ago

Ok, it's rebased on master now.

makermelissa commented 4 years ago

Awesome! Thank you.